[3.0] Change likes to reactions...#8187
Conversation
Signed-off-by: Michael Eshom <oldiesmann@gmail.com>
Oldiesmann
changed the title
|
Also cc @Sesquipedalian since this will require changes to the DB schema stuff in #8093 |
|
Good job. IMO this also should be done for 2.1 |
|
2.1 is feature frozen and receives bug fixes only.
…On Sun, May 5, 2024 at 9:52 PM asmith20002 ***@***.***> wrote:
Good job. IMO this also should be done for 2.1
—
Reply to this email directly, view it on GitHub
<#8187 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJNN5J44LLS3XBZI3OVHLZA4EAPAVCNFSM6AAAAABG3Y3IX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJVGE4TIOJXGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
latest upstream changes
Signed-off-by: Michael Eshom <oldiesmann@gmail.com>
Signed-off-by: oldiesmann <oldiesmann@gmail.com>
It doesn't work if I run it locally because of all the index.php files SMF sticks within vendor and its various subdirectories - it just ends up pulling in SMF's own index.php file and generates whatever output is generated from that. |
|
Have you tried it recently? The .php-cs-fixer.dist.php file is configured to ignore anything inside the vendor dir. |
|
If I run it from the directory with the now-fixed files, it complains that Settings.php isn't readable, and if I copy Settings.php to the directory, it'll just spit out the HTML for the error message saying SMF can't connect to the database. If I run it from a live local test board, it spits out HTML. 
|
|
Hm. You are correct. I will fix this soon. |
|
Please see #9114 for the fix to your problem, @Oldiesmann. |
…tions Signed-off-by: oldiesmann <oldiesmann@gmail.com>
7 participants
This PR changes SMF's likes feature into a full-fledged reactions system.
Features:
Admins can add/remove reactions as desired (only limit is defined by the limits of the SMALLINT data type, which should be plenty)
For simplicity, it will use images in a reactions folder in the theme's images folder and will look for a $txt['react_{name}'] string for i18n (defaults to 'name' defined in the database if not found)
Work done so far:
Still to do:
Note that the upgrade uses a combination of db API functions and upgrade_query. In some situations (such as creating a table), upgrade_query is far simpler than the associated db API call.